Fix errors with latest @babel/generator
#245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few separate but related issues have popped up as our upstream dependencies (specifically the Babel-related ones) have evolved lately:
generate(someTSTypeParameterDeclarationNode)
throw, as it now cares about details of its parent node. Babel should maybe handle that more gracefully, but it's trivial for us to work around by generating code for the declarations individually rather than altogether.The Browserslist issue was a ticking timebomb we would have hit eventually regardless, but a few different consumers ran into the
@babel/generator
just from refreshing other random dependencies and happening to get a Babel update. To help get ahead of that situation in the future, I'm also adding a floating dependencies scenario to our CI config.